OCM 3993 | Feat | Add GCP marketplace terms and conditions for marketplace GCP clusters #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/ocm/create/cluster/cmd.go
Outdated
| @@ -533,6 +546,14 @@ func preRun(cmd *cobra.Command, argv []string) error { | |||
| if isGcpMarketplace { | |||
| fmt.Println("setting ccs to 'true'") | |||
| args.ccs.Enabled = true | |||
| fmt.Println("Review and accept Google Terms and Agreements on", gcpTermsAgreementsHyperlink) | |||
There was a problem hiding this comment.
should it be Terms and Conditions instead?
There was a problem hiding this comment.
We are keeping it consistent with the UI : https://docs.google.com/document/d/1xpRCZ0QYWRuvVtCEycWrHwXWSIepzUkgb8Nobqf3Dlc/edit#heading=h.ve1e69gtx5pl
cmd/ocm/create/cluster/cmd.go
Outdated
Comment on lines
531
to
532
| fmt.Println("setting provider to", c.ProviderGCP) | ||
| fmt.Println("setting ccs to 'true'") |
There was a problem hiding this comment.
this change the behaviour: why do we only show the message/override the ccs and cloud provider attributes in the interactive mode?
There was a problem hiding this comment.
Added the prompt messages for non-interactive mode as well
|
LGTM |
cristianoveiga
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Tested